-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
607 update eo to 0.50.0 #617
Conversation
@yegor256, for some reason, the pipeline fails Environment:
Commands:
|
@deemp use |
@yegor256, should |
@deemp yes, exactly |
@fizruk, dataization of the celsius example produces bytes for some reason.
|
@fizruk, @yegor256, I tried to implement the syntactic sugar for such expressions
but then got shift-reduce conflicts. I had the following definitions in the Syntax.cf.
I think when parser encounters @yegor256, can you temporarily support a special syntax for such sugar? Example:
Then, I can avoid conflicts by using:
|
@deemp I'm not sure I understand what's the source of the shift-reduce conflict:
This text is not clear for me. Can you elaborate a bit further? |
@deemp BTW, this EBNF we use to parse phi expressions, maybe will help: https://camo.githubusercontent.com/77e1ebd2a73dbe1889a630de643778e76b81b406bf1bdae75be8f833ac67f791/68747470733a2f2f7777772e656f6c616e672e6f72672f65626e662f5068692e706e67 |
@yegor256, you use ANTLR which generates top-down (LL) parsers. We use BNFC which generates bottom-up (LR) parsers. We use BNFC for convenience. A GLR parser could try multiple options.
However, currently, BNFC-generated parser (using the
Hence, we have to use a LR parser which can't try multiple options and thus gets a shift/reduce conflict. @fizruk, please correct me if I'm wrong. I see the following options:
|
- signed integers - signed doubles - literals inside applications - attributes
54b2c89
to
6538210
Compare
574cbd7
to
93bf014
Compare
@fizruk, some dataization tests still fail. Please check. |
f79254d
to
4592325
Compare
4592325
to
094838f
Compare
7ecda29
to
e9c22c3
Compare
70db1ee
to
48692da
Compare
- support attribute sugar for phi - improve error reporting - remove some old code
6f88439
to
0e5788b
Compare
Changes: